-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow passing device context to interact call #1093
feat: allow passing device context to interact call #1093
Conversation
lib/idx/interact.ts
Outdated
recoveryToken | ||
recoveryToken, | ||
|
||
// X-Device-Token header need to paire with `client_secret` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit "pair"
Codecov Report
@@ Coverage Diff @@
## master #1093 +/- ##
=======================================
Coverage 92.89% 92.89%
=======================================
Files 142 142
Lines 3912 3913 +1
Branches 815 816 +1
=======================================
+ Hits 3634 3635 +1
Misses 278 278
Continue to review full report at Codecov.
|
@@ -18,6 +18,7 @@ const express = require('express'); | |||
const session = require('express-session'); | |||
const mustacheExpress = require('mustache-express'); | |||
const path = require('path'); | |||
require('express-async-errors'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
due to v6 change, idx errors is thrown directly now, add this middleware for error handling purpose
This reverts commit 6f57d4b.
OKTA-452538 <<<Jenkins Check-In of Tested SHA: a8827b8 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 5 PR Link: "#1093"
No description provided.